Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide additional documentation for advance parameter usage with Register-C4bEndpoint.ps1 #1118

Merged
merged 2 commits into from
Jan 17, 2025

Conversation

steviecoaster
Copy link
Contributor

Description Of Changes

Adds additional information and examples for using advanced parameters available when running Register-C4bEnvironment.ps1 from a Chocolatey environment.

Motivation and Context

We added new parameters and capability, and need to instruct users on their use.

Testing

  • I have previewed these changes using the Docker Container or another method before submitting this pull request.

Change Types Made

  • Minor documentation fix (typos etc.).
  • Major documentation change (refactoring, reformatting or adding documentation to existing page).
  • New documentation page added.
  • The change I have made should have a video added, and I have raised an issue for this.
    • Issue #

Change Checklist

  • Requires a change to menu structure (top or left-hand side)/
  • Menu structure has been updated

Related Issue

Fixes #1117

…rization options

This commit adds new documentation about the parameters that are available to pass as part
of registering a new endpoint into the Chocolatey solution.
Copy link
Member

@ryanrichter94 ryanrichter94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few preliminary read-through comments.

With this commit a new page has been created which provides examples for using the new parameters
available to users when running the Register-C4bEndpoint.ps1 script on a new endpoint.
Copy link
Member

@ryanrichter94 ryanrichter94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the edits 🚀

@steviecoaster steviecoaster requested review from st3phhays and removed request for JPRuskin January 17, 2025 17:39
Copy link
Member

@st3phhays st3phhays left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Based on other reviews, I'm going to approve this so it can be merged.

@st3phhays st3phhays merged commit 363b57b into chocolatey:master Jan 17, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Document new parameters available in Quickstart Environment
3 participants